[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: A few more niggles in the property editor

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 30 Apr 2010 18:41:38 +0200

On 30.04.2010 18:19, Oddvar Kloster wrote:
>>> 4. If I edit the svn:externals property using the Advanced mode
>>> and create an illegal value, then press OK, an error pops up and
>>> the
>> change
>>> is not made. I think it would be better to allow the change and
>>> flag
>> a
>>> warning instead. Sometimes the Advanced mode is more practical,
>>> and losing (imperfect) work is annoying.
>>
>> Showing only a warning but still apply the property would mean to
>> call the set-property API twice. Also, those errors only show up
>> for svn properties, and I don't think allowing invalid values for
>> those properties is a good idea at all, even if we show a warning.
>
> How about not closing the Edit Property dialog if an error occurs, to
> give the user a chance to correct his mistake?

I search the svn API - maybe there's a 'check property' function in
there we could use...

>
>>
>>> 5. The editor converts old style externals<path> -r<rev> <url>
>>> to
>> new
>>> style externals by setting the peg revision:<url>@<rev> <path>.
>>> Is there any reason for this?
>>
>> Yes: we have to create the property value from various data.
>> Allowing the old style would mean writing two completely different
>> functions which have the same effect and also writing a parser to
>> find out from an existing prop value whether it's in old or new
>> format. So I just used the new format because that's also the
>> recommended one now.
>
> I did not phrase the question carefully enough. Using the new format
> only is sensible, but why set the peg revision? I would expect a
> conversion to the format -r<rev> <url> <path>.

The peg revision is required in case the branch/tag gets deleted.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2599860
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-04-30 18:41:45 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.