[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [thg-dev] TortoiseOverlays 1.1.0

From: Adrian Buehlmann <adrian_at_cadifra.com>
Date: Sun, 21 Mar 2010 14:49:59 +0100

On 21.03.2010 14:04, TK Soh wrote:
> On Thu, Mar 18, 2010 at 1:25 PM, Adrian Buehlmann <adrian_at_cadifra.com> wrote:
>> (cc-ing tortoisehg-develop_at_lists.sourceforge.net)
>>
>> Apparently, if
>>
>> HKCU/Software/TortoiseOverlays, ShowUnversionedOverlay
>> HKCU/Software/TortoiseOverlays, ShowIgnoredOverlay
>>
>> are not set (in the registry of the user!), then these icons are now
>> dropped, starting with version 1.1.0 of TortoiseOverlays.
>>
>> http://code.google.com/p/tortoisesvn/source/detail?spec=svn18986&r=18986
>>
>> This is a very surprising change to be done on a shared component.
>
> I have not gone through the thread, but it does sound like a very
> drastic move. One would expect they at least attempt to maintain
> certain level of backward compatibility with the existing
> applications.
>
> I wonder what lead to such decisions.
>

The slot handler problems Windows presents are a bit complicated.

I somewhat misrepresented the situation in so far, as that when these
values do not exist in the registry, then the icon handlers are *not*
dropped (as Stefan pointed out on svn-dev). For that, I do apologize.

But still, the current settings dialog in TortoiseSVN suddenly became a
global one after that change (although per user, not per machine, just
to be clear), affecting *all* Tortoises for that user (not just
TortoiseSVN). In addition to the preexisting per-user global icon
selection (global=affecting all Tortoises).

But Stefan's changes are good.

Stefan now extended that new dropping mechanism in TortoiseOverlays
1.1.1 (which is now in the THG stable branch) to even more overlay
handlers, which is now beneficial for TortoiseHg too, as it allows users
to drop slot handlers which TortoiseHg doesn't use (e.g. Locked,
Readonly, Ignored). This is very good for situations where users have
installed additional software, which uses overlay slots too.

All in all, the situation is now not that bad as I first feared.

The underlying problem here is that TortoiseOverlays (TO) had a lot of
handlers from the beginning. Windows 7 introduced yet more handlers for
Windows itself, without increasing the max number of handlers it can
take. This resulted in one of THG's handlers (Unversioned) being defunct
on a pristine install of Windows 7.

TortoiseOverlays has had an automatic dropping mechanism for quite some
time now, dropping handlers based on some fixed priority order. That
priority was somewhat unfortunate for THG, as the first handler that it
dropped was the Unversioned, causing the Unversioned handler to be
defunct on Windows 7 (although I admit the Unversioned is not an
essential one). This dropping mechanism was already changed for TO
1.1.0. Now TO drops the Locked handler first. Which is a big concession
of Stefan for DVCS Tortoises, as the Locked handler is quite important
for TSVN.

The automatic dropping mechanism is good and needed.

In short: the basic problem is the limited number of slot handlers of
Windows, aggravated by Windows 7. And the result we currently have with
TO 1.1.1 isn't that bad.

I'm going to add the UI checkboxes for dropping the additional handlers
in TO 1.1.1 (Locked, Readonly, etc) now to THG. The ones of TO 1.1.0 are
already there.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2462788

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-03-21 14:53:54 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.