Re: TortoiseOverlays 1.1.0

On 18.03.2010 20:20, Adrian Buehlmann wrote:
> On 18.03.2010 18:21, Stefan Küng wrote:
>> On 18.03.2010 14:25, Adrian Buehlmann wrote:
>>> (cc-ing tortoisehg-develop_at_lists.sourceforge.net)
>>>
>>> Apparently, if
>>>
>>> HKCU/Software/TortoiseOverlays, ShowUnversionedOverlay
>>> HKCU/Software/TortoiseOverlays, ShowIgnoredOverlay
>>>
>>> are not set (in the registry of the user!), then these icons are now
>>> dropped, starting with version 1.1.0 of TortoiseOverlays.
>>
>> Are you sure?
>> If the registry value is not set (i.e., does not exist), the overlays
>> are not dropped (at least that's how it is supposed to work).
>
> I wouldn't call that "work". They are dropped if these values are zero.

Yes, but the user has to set those to zero. If they don't exist, their
value is not zero.
So a user action is required before those handlers are disabled. They're
not disabled by default.

> BTW, this was introduced in the very same change r18986 that was sold as
> switching the dropping priorities:
>
> http://code.google.com/p/tortoisesvn/source/detail?spec=svn18986&r=18986

Yes.

>> Only if you create the registry key and set its value to 0, *then* the
>> overlays are dropped.
>
> Sure. I see that in the code.
>
> So, if a user that happens to have TortoiseSVN installed sets his
> setting using the GUI of TortoiseSVN to not show the Ignored or
> Unversioned overlays, they are dropped by TortoiseOverlays.
>
> Is this the way a shared component is supposed to work?
>
> TortoiseSVN (=a client of TortoiseOverlays) decides to drop an overlay
> shared with TortoiseHg?
>
> Great. I might as well put a GUI in the TortoiseHg installer to "drop"
> the Locked, Readonly, and Ignored overlays by removing them from
> "Software\Microsoft\Windows\CurrentVersion\Explorer\ShellIconOverlayIdentifiers".

If you provide an UI to enable those again, sure, go ahead.

> Or I could add a button to the TortoiseHg shell extension settings tool
> labeled "Redeem overlays wasted for TortoiseSVN", acting on
> "Software\Microsoft\Windows\CurrentVersion\Explorer\ShellIconOverlayIdentifiers".
>
> Or leave away these GUI things altogether and remove them
> unconditionally on install. After all, we (=TortoiseHg) happen to not
> need them.
>
> Do you see the problem?

Calm down please.
If you recall, the same applies when the user decides to change the
overlay icons: they get changed for all Tortoise clients at once.

And we won't drop the UI for that in our settings dialog either.

If a user decides to not have the ignored/unversioned overlays show up,
then yes, they won't show up for any Tortoise client.
But the user can as easily enable them again if needed.

And you might have noticed that I haven't used the TSVN registry
settings for this but created new ones. So even if a user has already
disabled those in TSVN, they won't be disabled once he or she upgrades.
So THg will have those enabled until the user explicitly disables them.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2461816
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].