[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch: Wrong ownership sematics for BSTRs

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 12 Jan 2010 10:15:28 +0300

Stefan wrote:
>There were still four compiler errors. Don't you compile your changes?
>Or test them first?
The problem is I still haven't forced myself to compile all the stuff TSVN depends on (like whatever apr.h comes from), so I can't compile the project and only test snippets in my own codebase, but that of cource doesn't guarantee against some minor compilation problems. This is the primary reason I never send patches with new functionality, only "code rewrites".

Here's more - safe arrays also leak badly - sometimes the call to release them is just absent, sometimes it is skipped because of bailing out early.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2436542

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2010-01-12 09:52:03 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.