[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] :Updated - Fix for ambiguous Error Message in Log Command.

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 05 Jan 2010 20:36:51 +0100

On 05.01.2010 10:14, Ramasubramanian Sambamurthy wrote:
> When “show log” command is used with “show range” option with any of the
> two revision numbers greater than HEAD revision, irrelevant Error dialog
> is shown. Fix is done such that appropriate error message will be
> displayed in display window when any of the given revision number is
> greater than HEAD Revision.
>
> * TortoiseSVN/src/TortoiseProc/LogDialog/LogDlg.cpp:
>
> (GetAll)
>
>
>
> Check is done whether startrev is greater than HEAD Revision and if any,
> Appropriate Error message is shown in Display window.
>
> * TortoiseSVN/src/TortoiseProc/LogDialog/LogDlg.h
>
> Declaration of a variable m_head is done.
>
> Patch by: Ramasubramanian S V <svram_at_collab.net>
>

Committed with modifications in r18190.

Some comments about what I've changed:
* you forgot to initialize the member head variable
* the member head variable wasn't set when the log dialog was started
for another start or end revision than head (can happen e.g. when
started from the revision graph, repo browser or even the log dialog itself)
* you used a fixed string for the error message instead of a resource string

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2435000
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-01-05 20:37:02 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.