Re: Patch: Remove redundant checks

Stefan wrote:
>> Also in TortoiseProc/Revisio​nGraph/SearchPathTre​e.cpp I found some
>> strange code pattern that I marked with a comment. I suggest it is
>> reviewed - looks like a severe bug.
>That code is actually correct.
Then I don't get what is meant there. What I see is the following: if "firstChild" is a null pointer nothing happens, but if it is not a null pointer "delete firstChild" is done, "firstChild" is not changed and remains not-null, so the while-loop continues forever and each iteration starting with the second one performs "delete" on an already deleted pointer. Did I miss anything?

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2432538

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-12-23 09:58:08 CET