[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suggestion for "select all" functionality in Commit dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 04 Jun 2009 17:30:09 +0200

Simon Large wrote:
> 2009/6/4 Lübbe Onken <luebbe.tortoisesvn_at_googlemail.com>:
>> Hans-Emil Skogh wrote:
>>> [Link color]
>>>>> Black would be my initial choice as well, but I'll give it a couple of
>>>>> weeks and we'll see.
>>>> I've changed the color now back to black, but the font is now bold so
>>>> the links should be more distinguishable from normal labels.
>>> I think this looks slightly better. Lübbe, any thoughts? Does it look
>>> good to you?
>> Looks good to me. I have to admit that this is the first nightly that I
>> have installed for > two weeks, so I have neither checked the feature
>> nor participated in the discussion (a "bit" much work to do currently :/).
>>
>> So if this has been mentioned before and discarded, please disregard my
>> comment below.
>>
>> It feels unnatural to me that the selections are no toggles. E.g. if I
>> click on "Files" once, all files are checked, if I click on files again
>> nothing happens. I have to select "None" to deselect everything and
>> start over. If I wanted to select all modified files (but not the
>> directories) quickly, my action sequence would be:
>> - Click modified, (all modified objects are selected)
>> - Click directories once, (all directories are selected)
>> - Click directories again, (all directories are unselected)
>>
>> Maybe that doesn't make sense, but that was my first impression without
>> deeper thought.
>
> The way it works is like the selection options in gmail, except that
> the selections are additive.
>
> The problem with deselection is what to include, because some items
> will fall into more than one category, e.g. 'files' and 'modified'.
> e.g.
>
> - Click modified (all modified objects are selected)
> - Click files by mistake (all files are selected)
> - Click files again to undo that action (all files are deselected,
> including modified files)
>
>> One thing that I noticed while playing around with the selections. What
>> happens if I do the following:
>> - select a single changed file for commit
>> - "Show unversioned" (status tells me 12345 total 1 selected)
>> - select "all" (status tells me 12345 total 12345 selected)
>> - deselect "Show unversioned" (status tells me 1 total 1 selected)
>> - "OK" (I didn't dare :))
>>
>> Will the 12345, currently not visible, unversioned objects that I
>> selected, be added to the repository without further warning or will it
>> only the single changed file I selected in the beginning be committed?
>
> What happens in 1.6.x if you show unversioned items, select some and
> then hide unversioned items again? IMHO if something is hidden it
> should be automatically deselected.

It is automatically deselected.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2359472
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-06-04 17:30:32 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.