[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suggestion for "select all" functionality in Commit dialog

From: void pointer <rcdailey_at_gmail.com>
Date: Thu, 28 May 2009 15:20:05 -0500

On Thu, May 28, 2009 at 11:56 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:

>
> Hmm, on second thought:
> imagine a commit where tons of files/folders are added (more than fit
> in the items list of the commit dialog without scrolling). The default
> for the CM dialog is the automatically check all important items
> (those that require a commit). But since all added files/folders are
> already checked (clicking on the 'added' link would do nothing), the
> link is grayed out. But the user doesn't know that all those items are
> already checked and wonders why he can't check all added items.
>
> We could however gray out those options which never do anything, e.g.,
> gray out 'added' if there simply are no added items.

Again, I will emphasize my opinion on not graying anything out, as it
doesn't seem like it would confuse the user to see an "Added" link when
there are no added items in the CM dialog.

As for the additive selection scheme, I think I finally get what you're
saying. If the user wants to check in all added/deleted items, he first
clicks "None", to uncheck everything, and then clicks "Added", and then
"Deleted". If he happens to change his mind, and now wants only deleted
items, he has to again click "None" and then "Deleted".

Instead of graying out the link, why not just hide it? If you're going to do
this, it would be a lot less clutter to only show links for things that
exist in the commit dialog. For example, if there are only added and deleted
items in the CM list, you would have:

*Select: All, None, Files, Directories, Versioned, Added, Deleted*

However, if you have added, deleted, modified, and unversioned items, it
would be:

*Select: All, None, Files, Directories, Versioned, Unversioned, Modified,
Added, Deleted*

And likewise, if there were only files, and no directories, you would hide
"Directories".

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2356567

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-05-28 22:20:15 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.