[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: Bug in pathList parameter passed to IBugTraqProvider2 CheckCommit and OnCommitFinished

From: <webpost_at_tigris.org>
Date: Mon, 20 Apr 2009 11:51:09 -0700 (PDT)

Again responding to my own post...

Thanks for the fix for CheckCommit(). This gives me enough to continue what I was doing. However, this did not fix the call to OnCommitFinished, which is still showing the original symptoms I described.

I think I have found the code which needs to be changed to fix OnCommitFinished(). In CSVNProgressDlg::CmdCommit(), the call to OnCommitFinished is made with a copy of m_targetPathList. I think it should instead use m_selectedPaths. The m_selectedPaths variable is set by CSVNProgressDlg::SetSelectedList(),
which is called from CommitCommand::Execute(), with dlg.m_selectedPathList as the parameter, which is the correct list we need.

Hope this helps.

Jim Z.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1828723

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-04-20 20:51:33 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.