2009/2/9 Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>:
> Simon Large <simon.tortoisesvn_at_googlemail.com> wrote:
>
>> Deleted nodes use a rectangle with corners cut off, but it looks quite
>> similar to a rounded rectangle. For you and me the colour makes it
>> obvious, but if you don't have colour vision you need another clue,
>> which is where the shapes come in. As deleted nodes contain only a
>> revision number I suggest using a diamond shape, or maybe a pentagon
>> (see attached picture).
>
> I simply increased the portion cut off some time ago. Ordinary
> deletion nodes are now hexagons. If the deletion node needs
> to show the path, its shape may resemble 'rename' nodes but
> it has a different color.
That's my point. If you don't have colour vision you can't tell the
difference if the shapes are the same.
>> The colour settings specify the border colour, but the fill colour
>> seems to be a blend of the border colour and the background. In
>> particular tags seems to be a special case where the colour is blended
>> with yellow rather than anything the user specifies. If you use the
>> high contrast #1 then you get yellow text on a green/yellow
>> background, which is definitely not high contrast! Not sure what to do
>> here. I really like the colour blends as they are, but we need to find
>> a way of giving control to the user as well.
>
> r15294 adds a color settings page for the revision graph.
Looks good :-)
Can you explain what the trunk node colour is used for.
A tooltip showing the range of values for opacity would help too.
>> If you change to a high contrast scheme such as yellow text on black
>> (HC#1), the boxes around normal revisions disappear entirely. Looks
>> like their border colour is hard coded to black. I'm not sure what
>> defines some of the other outline colours.
>
> I just realized that 'special' nodes still have hard-coded border colors.
> Work for the next WE.
Yep, I noticed that too. Where you use a normal black border, i.e. the
same colour as the text you could just use the text colour rather than
add another choice to the settings.
The selection marker has no colour selection.
I also notice that WC change detection is not working at the moment,
at least not for folders. If I generate a fresh rev graph with that
option enabled, or if I enable the option and hit F5 I still don't get
a modified node.
Redrawing seems a bit unreliable (in XP SP3). If you drag another
window over the top of the rev graph it doesn't redraw fully until the
mouse goes over something that will pops up a tooltip or similar.
The progress dialog doesn't come up immediately either. Graphing
TSVN/doc I get about 5 seconds of blank grey background rev graph
window, then the progress dialog flashes up and the graph draws
instantly. Looks like the progress dialog is not shown until after the
respository has been contacted.
Simon
--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1130837
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-02-09 23:54:17 CET