[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Revision range in log dialog

From: Oddvar Kloster <Oddvar.Kloster_at_sintef.no>
Date: Wed, 4 Feb 2009 18:09:04 +0100

> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn_at_gmail.com]
> Sent: 4. februar 2009 17:32
> To: dev_at_tortoisesvn.tigris.org
> Subject: Re: Revision range in log dialog
>
> Oddvar Kloster wrote:
> > I'm a bit mystified by some behaviour of the log dialog.
> >
> > If I open the log for a folder, select revision 123 and then click
> > 'show log' for one of the files modified in that revision,
> I get a log
> > dialog for the file. This dialog does not show revisions after 123.
> >
> > Minor point 1. I'm not entirely sure that it's best to show the log
> > only up to revision 123 -- my thoughts were 'ok, this file was
> > modified here, let's see what other revisions we've modified it in'.
> > However, this may just be my preference.
>
> If you use the log dialog and start another log dialog from
> that, it's usually because you *want* to show the log for a
> specific revision - maybe the file/folder doesn't even exist
> anymore in HEAD. So we can not show the full log because we
> would get an error if the file/folder doesn't exist anymore in HEAD.
>

Yes, the file is defined by a name and peg revision and does not necessarily exist in HEAD. But if I want to see its entire history, I can achieve that by Refresh or Show Range to HEAD. So why not show revisions up to HEAD (or until the file is deleted) from the beginning?

> > I then try to get it to show the later revisions. First, I try to
> > change the filter To: date to today. But the date cannot be
> moved to
> > later. (Neither is it possible to show revisions earlier than the
> > first shown by changing the From: date to earlier.)
>
> The date controls work as a *filter* for already shown log entries.
>
> > Minor point 2. This is perhaps understandable from an
> implementation
> > point of view, if the dates just act as a filter on the
> already loaded
> > revisions, but it's not necessarily intuitive.
> >
> > Ok, let's try the Show All button. Nope, no revisions after 123. I
> > have to click Show Range... and select HEAD to see them.
> And then, if
> > I click Show All, it goes back to clipping at 123.
> >
> > Main point. Show All should always go all the way to HEAD.
> >
> > ... and then by accident I clicked Refresh and got the log to HEAD.
> > That was unexpected...
>
> That's all by design. I explained why above...
>

Maybe I should rephrase: Show All should always go all the way to HEAD or to the point where the file is deleted.

When showing the log from a peg revision, it would also be sensible to note the peg in the log window title.

> > Another thought: How about some visual sign when the revision range
> > shown is restriced. For example an extra revision line at
> the top or
> > bottom showing '...' as Revision and otherwise blank?
>
> Could be done, yes. I'll keep a note...
>
> Stefan
>
> --

Oddvar

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=1102983

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-02-04 18:09:17 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.