[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Drives A: and B: assumed to be floppies, even though they may not be

From: Stefan Kueng <tortoisesvn_at_gmail.com>
Date: Sun, 14 Dec 2008 14:11:00 +0100

David Ellsworth wrote:
> Hi Stefan,
>
> I've encountered a bug in TortoiseShell. It assumes that drives A: and
> B: are floppy disks, but hard drives can be remapped to these drive
> letters in Windows NT/200x/XP/Vista. For me, drive B: is a large RAID 5
> volume; I wanted it to precede C: which is my Windows system drive, and
> find this mapping to be quite convenient (especially since my current
> motherboard's BIOS doesn't even allow me to attach two floppy drives).
> But TortoiseShell forces me to enable Icon Overlays for "Removable
> drives" and "Floppy drives (A: B:)" to get them to work on my drive B:.
>
> I didn't have this problem before upgrading to the latest version of
> TortoiseSVN a while ago. Why was this change made?
>
> I've created a tiny patch (attached) which should fix the problem,
> though I am unable to compile TortoiseSVN at present.

Thanks for the patch. I didn't use your patch though but changed the
behavior a different way.
The reason that A: and B: were treated separately is because the
GetDriveType() API accesses the drives. And in case of floppy drives,
that makes them 'spin' (you can hear the read head seek around) and
that's very annoying. That's why we just assumed A: and B: to be floppy
drives.

I've changed it so that you have to enable A: and B: separately (but
without having to enable removable drives).

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=984087
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2008-12-14 14:11:26 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.