[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Log cache and revprop edits

From: <Stefan.Fuhrmann_at_etas.com>
Date: Thu, 29 May 2008 22:02:45 +0200

"Larry Shatzer, Jr." <larrys_at_gmail.com> wrote on 05/27/2008 09:22:34 PM:

> From the "Show log" dialog, if I go to any older revision and show the
revision properties and
> make an edit to any of the svn: revprops, I have to update the cache by
hand for the log view to
> be updated. Of course you can use the edit author or edit log, and it
updates it automaticly. I
> only bring this up, since I was testing editing of the date to debug a
problem, and the date was
> not refreshed unless I either updated the cache. I would think the code
that "edit author" and
> "edit log" that updates the cache would also be called when any of the
revprops are edited via the
> revision property edit panel, just in case one of the svn: entries was
updated.

Thanks for the report, Larry.

I just had a look at the code and the fix would not
be local enough to do it in 1.5. It's not too complicated
but not entirely straightforward either. And CRTL-F5 as
a workaround is hopefully not too painful.

The problem is that there is only one prop-edit dialog
class that handles revprops from the log dialog as well
as from the repobrowser, and of curse the normal item
properties.

So, there is some risk that an extra call to "update the
log cache as well" may break TSVN under rare conditions.
For instance, a user could (maybe accidentally) add a
"svn:log" property to some file. Chances are that things
would go berserk.

Putting it on my 1.6 TODO list.

Sorry!
-- Stefan^2.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-05-29 22:02:59 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.