> Q: context menu icons don't show up if Windowblinds is installed
> A: that's a bug in WindowBlinds which the company is unable to fix due
> to lack of experienced developers and crappy support people. Even though
> the fix would be easy and we told them how to do it, they're still not
> able (or willing) to fix this. Please complain to their support, not
> ours as we have done everything we could.
>
> :)
With all due respect to the original poster, they did not state the
operating system they were using (XP), nor that they were using the
unreleased RC 1.5 version of TortoiseSVN. Due to the way in which
TortoiseSVN's code is structured, the bug is not evident on Vista, and
the code concerned is not in 1.4.8. I am not the WindowBlinds
developer and I do not know exactly how far they went in trying to
debug this problem, but if they had tried it with the information they
were given, it is unlikely that they would have seen it.
I notice your icon handling code has also been completely overhauled
since 1.4.x:
http://tortoisesvn.tigris.org/svn/tortoisesvn/branches/1.4.x/src/TortoiseShell/ContextMenu.cpp
http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseShell/ContextMenu.cpp
I understand patches were contributed by Adam Strzelecki.
Have you tried stepping through CShellExt::HandleMenuMsg2 with
WindowBlinds loaded to see that the expectations of the code are being
met - or that this code is being called at all? It seems like that
would be a reasonable step to take on your end, rather than guessing
about whether it does. It would also be possible for you to see if
different figures are passed for the fields of MEASUREITEMSTRUCT/
DRAWITEMSTRUCT in the skinned and unskinned cases.
The TortoiseSVN handlers for WM_MEASUREITEM and WM_DRAWITEM are much
shorter than they used to be, and I wonder if they have all that is
required. For example, WM_MEASUREITEM seems to be assuming that
increasing the current width of the item by two is sufficient.
Conversely, in 1.4.x code, it is set to "width of string + height of
string (~ width of icon) + space between".
As stated in http://www.nanoant.com/programming/themed-menus-icons-a-complete-vista-xp-solution
the HBMMENU_CALLBACK path for the code now in 1.5 does not work all
that well on 2000, cutting off all the text (hence it is only used for
XP). I have to wonder whether this is, as he states, "obviously a bug
of Windows 2000 shell.dll". If the width of the item is not explicitly
set but assumed to be "some value + 2", it seems like that would
naturally remove most or all of the text if 0 is passed.
Now, the problem may well still be in WindowBlinds. The above is just
an example of an assumption that would be worth checking before
blaming us. We have seen a lot of situations where code simply "happen
to work" - perhaps a return parameter is not checked, or a complete
drawing area is used rather than the one specified. Naturally, if it
fails to happen to work when WindowBlinds is loaded, the fault is then
seen as ours . . .
A skin that demonstrates this problem is Vector-Cell, which can be
downloaded at http://www.wincustomize.com/skins.aspx?skinid=4350&libid=1
--
Laurence "GreenReaper" Parry
Stardock Development
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-05-24 08:46:10 CEST