[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Incorrect return value from CHooks::RunScript when CreateProcess fails

From: Roger Lipscombe <roger_at_differentpla.net>
Date: Sat, 19 Apr 2008 08:42:10 +0100

RunScript is supposed to return the exit code from the script. If
CreateProcess fails, however, it calls SetLastError, and then returns
FALSE. This is wrong. It should probably return -1, as it does in the
other failure cases.

(Unfortunately, for various non-technical reasons, I can't create a
patch right now).

Cheers,
Roger.

P.S. Yeah, I'm finally getting around to changing the hooks to not block
the UI...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: dev-help_at_tortoisesvn.tigris.org
Received on 2008-04-19 09:42:32 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.