[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [nightly build r11440] Revison Graph doesn't show Author, Date, and logmessage

From: <Stefan.Fuhrmann_at_etas.com>
Date: 2007-11-28 13:00:27 CET

Stefan Küng <tortoisesvn@gmail.com> wrote on 27.11.2007 19:52:29:

> The CRevisionInfoContainer has a member array containing the sum (OR)
> changes of a revision. That array is calculated by the
> CalculateSumChanges() method: but that method is only called when the
> cache is loaded from disk!

CalculateSumChanges() calculates the cummulative change flags
for *every* revision. Despite taking a long time, this should
only be necessary after loading the data from disk because the
sumChanges member will not be stored (redundant information).

> When adding revisions one-by-one in memory (not from the load-from-disk
> operator), then the sumChanges array isn't properly updated --> the
> revision graph misses all the copies.

Thanks for finding this! In fact, the sumChanges got updated
but the HAS_COPY_FROM flag would not be set. So, they got all
skiped by the revision graph.

Fixed in r11466.

-- Stefan^2.
Received on Wed Nov 28 13:06:06 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.