[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bug: duplicated files on commit dialog

From: Rob Hubbard <hubbard.r_at_gmail.com>
Date: 2007-10-31 11:46:10 CET

Dear TSVN Developers,

(Thanks to you, and the Subversion developers, for SVN and TSVN, both
of which are excellent, and still improving.)

I think I've found a minor (but potentially confusing) bug in TortoiseSVN.

Symptom: a file can be listed more than once on the commit dialog.

Steps to reproduce:
(Here I use <angle brackets> just to quote names or menu items.)
* Suppose you have a working copy directory <dir>
* Modify and/or add a file <dir/file.txt>
* Modify the properties of <dir> e.g add a property <prop> with value <val>
* Choose <SVN Check for modifications> from the context menu of <dir>;
    you should see both <dir> and <dir/file.txt> listed
* Select all files (e.g. with Ctrl-A)
    (in fact, you can select any subset of files including both <dir>
and <dir/file.txt>)
* Choose <Commit> from the context menu for the selection
    you should see <.> listed once but <file.txt> listed *twice*

I have tried this with the latest client, TSVN 1.4.5 build 10425, 64
Bit. I've looked for this problem on the bug tracker and this mailing
list, but didn't find it; sorry if it's already there but I missed it.

This problem does *not* occur if commit is chosen from the directory's
context menu directly, i.e. without going via the modifications
dialog.

I expect that the reason <file.txt> is listed twice is that it has in
effect been selected twice: once as itself, and once recursively under
its containing directory.

Now some confusion may arise if a user deselects a file (which he
hasn't noticed is duplicated) and it gets committed anyway.

I can see two potential fixes. Such duplicates could be detected and
removed. Alternatively, selecting a directory from a file list in the
modifications dialog should not be recursive.

I'm not subscribed to this list, so could you please copy me on replies?

Thanks,
Rob.

Rob Hubbard.

PS. I know that emails should stick to one subject, but these are all
related to the above and to each other...

Related feature request [1]: to have shallowly and/or deeply recursive
selection and deselection options on the context menu for files on the
commit dialog.

Related feature request [2] (if selection of directories on the
modifications dialog is not to be recursive): to have an option to
show (unselected) any files or directories below any already listed on
the commit dialog.

Related feature request [3]: to allow navigation upwards (i.e. to
<..>), but retaining the selection, on the commit dialog.

Related feature request [4]: to allow commit of more than one disjoint
working copy directory for a given repository as an atomic
transaction. That is, to allow a commit request to be merged with an
existing open commit dialog.

Thanks again,
Rob.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 31 11:51:31 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.