[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crash in TMerge

From: Harun Vos <hvos_at_lynx.com.au>
Date: 2007-10-11 06:35:31 CEST

I have managed to reproduce this, or something similar.
It doesn't crash for me as you describe it, Simon - I need an extra step:

3. Right click on a word in the top line in the left pane.
 3a Right click on 'Use this text block' in the context menu.
     This doesn't close the menu, but it does remove the black border from the selected line.
4. Select 'Use this text block' from the context menu.
5. Kaboom

This crashes for me (on 2000 and XP), with the latest nightly, r10947.
Is this the same as your crash?

It looks like the "case ID_USEBLOCK:" code in "void
CLeftView::OnContextMenu(CPoint point, int /*nLine*/, DiffStates state)"
(leftview.cpp, beginning line 168)
is passing a -1 value from m_nSelBlockStart as an index to
m_pwndRight->m_pViewData->GetLine(i).
The same applies to CRightView in reverse.
I don't know why it is -1, or what it should be - someone more familiar
with the code than me will need to look into this.

Hope that helps.

Harun Vos

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Oct 11 06:42:50 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.