RE: Keyboard shortcuts in log

> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
> Thanks for the patch!
> I have some comments though:
> * we disabled the diff for doubleclicks a long time ago
> because accidental doubleclicks (yes, they happen more often
> than you might
> think) would lead to sometimes lengthy operations which the
> user didn't wanted. So if you really want to do this, you'd
> have to add an option to disable that feature - best in the
> "Dialogs 1" page under "Log messages". Just move the
> "Progress", "Merge" and "Checkout" groups a little bit down
> and you'll have enough space for another checkbox.

It's true that the operation can take a long time, but in that case a progress window appears and allows the user to cancel. I guess this might not have been in place when you disabled the doubleclick? Is avoiding accidental diffs still important enough to warrant the option?

> * you removed the tab stops from the edit boxes in the file
> diff dialog.
> Why? Users still want to tab into those to copy the text from there.

I tested that before disabling them, but was not able to copy the text in those boxes...
Anyway, I did it because I could not get the dialog to start with focus on the main list. I've now managed this, so the stops are restored.

> * You used the OnOK handler for catching pressing Enter and
> then checked for the focus. That's the wrong way! By doing
> this, you break tools that send specific messages to our
> dialogs (e.g., remote control tools, automation tools, ...).
> Instead, you should catch the NM_RETURN message sent by the
> list control.

I agree, but I've not been able to catch NM_RETURN. I found a few similar complaints on the web, and the only fix described was using OnOK. Any suggestions are appreciated...

> From: Alexander Klenin [mailto:klenin@gmail.com]
...
> Finally, code form CLogDlg::DiffSelectedRevWithPrevious
> function in the patch seems vaguely familiar -- was it
> copy-pasted from other function?
> If so, perhaps a better way is to extract common code?
>

Most is from ShowContextMenuForRevisions, but there it's interleaved with context menu code, so I don't see how to make a common version.

Oddvar

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 10 15:17:45 2007