[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10898 - trunk/src/TortoiseProc/CommitDlg.cpp

From: Alexander Klenin <klenin_at_gmail.com>
Date: 2007-10-06 18:23:41 CEST

On 6 Oct 2007 15:11:10 -0000, steveking@tigris.org <steveking@tigris.org> wrote:
> Author: steveking
> Log:
> Remove compiler warning.
==============================================================================
> --- trunk/src/TortoiseProc/CommitDlg.cpp (original)
> +++ trunk/src/TortoiseProc/CommitDlg.cpp 2007-10-06 08:11:10-0700
> @@ -871,9 +871,16 @@
> // add the path parts to the autocompletion list too
> CString sPartPath = entry->GetRelativeSVNPath();
> m_autolist.insert(sPartPath);
> +
> + int pos = 0;
> int lastPos = 0;
> - for(int pos = 0; pos = sPartPath.Find('/', lastPos) + 1; lastPos = pos)
> + while ((pos = sPartPath.Find('/', pos)) >= 0)
> + {
> + lastPos = pos;
> + pos++;
> m_autolist.insert(sPartPath.Mid(pos));
> + }
> +
> // Last inserted entry is a file name.
> // Some users prefer to also list file name without extension.
> if (CRegDWORD(_T("Software\\TortoiseSVN\\AutocompleteRemovesExtensions"), FALSE))
>

It seems that my change is to blame, sorry.
What was the warning?
I have edited and re-compiled this file many times, without any warnings.
Anyway, your commit changes the semantics of the loop slightly.
I will fix it, but I want to know the warning you received so I can
try to avoid it.

-- 
Alexander S. Klenin
Insight Experts Ltd.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Oct 6 18:23:57 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.