Re: Early warning: Major log cache code update

On 10/5/07, Alexander Klenin <klenin@gmail.com> wrote:
> On 10/5/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> > > * Refresh in log dialog shall update the head revision
> > > (e.g. "any new revisions?") as well as update authors and
> > > comments in the revisions shown.
> >
> > I think to update authors/comments, the users can use the 'clear log
> > cache' in the settings dialog. A refresh in the log dialog should not
> > invalidate the cache IMHO.
> I disagree due to several reasons:
> 1) 'Clear log cache' is not good interface for this, since it is
> inconveniently located and,
> AFAIK, clears all cache for all working copies instead of just current one.

As I said, there's an issue open for this:
http://issues.tortoisesvn.net/index.php?do=details&task_id=378

> 2) I think that correctness should come before speed here, if user
> requested a refresh,
> he expects to see current information, not stale copy of it.

And how many times does that information change?
No, speed is important here. Users use the refresh feature not to get
rid of the stale copy but to check if there are new commits.
For those 1% where the author/comment really changed, a Ctrl-F5
refresh isn't too much to ask. I don't like to degrade the speed for
the other 99%.

> 3) Finally, what would be the purpose of refreshing if it will just
> re-read the cache?
> If you think cache invalidation aspect should be emphasized in the name,
> how about calling it 'Refetch'?

It won't just reread the cache, it would check if there are new
commits and load those.
Otherwise the whole refresh would be pretty much useless.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org