[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Revision Graph crashes if the log message is written in Japanese

From: masaru tsuchiyama <m.tmatma_at_gmail.com>
Date: 2007-07-22 05:55:09 CEST

I found a bug on Revision Graph.
It crashes when showing the log message which is written in Japanese.

The crash happens at the below code in CRevisionGraphWnd::OnToolTipNotify.
        if (rentry->tagNames.empty())
        {
            strTipText.Format(IDS_REVGRAPH_BOXTOOLTIP,
                                            rentry->revision,
                                            rentry->realPath.GetPath().c_str(),
                                            revisionInfo.GetAuthor(index),
                                            date,
                                            revisionInfo.GetComment(index).c_str());
        }

At the time, revisionInfo.GetComment(index).c_str() is an endless string,
It has no \0 termination.

And I attach a repository dumpfile which can reproduce the crash.
If you move the mouse cursor to revision 1, "Revision Graph" crashes.

Regards.
Masaru.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Sun Jul 22 05:54:11 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.