[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug or Feature? Commit Selection ignored

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-05-16 15:42:36 CEST

On 5/16/07, Slim and Steve <slimandsteve@gmail.com> wrote:
> Stefan Küng <tortoisesvn <at> gmail.com> writes:
>
> > > A) Just treat the checkmarked/selected files/folders as a list and process
> it
> > > just as svn ci -F <filelist> would do. No file system monitoring necessary.
> >
> > Not possible. If we would do that, then we'd have to stick to
> > non-recursive commits. And non-recursive commits can't commit folder
> > deletions.
> > --> we *must* commit recursively if the user has everything selected.
>
> I don't know about the internals of TSVN, but with DOS I do a recursive status,
> then have a filelist with absolute paths which I can commit with the -F option.
> The list in the commit dialog knows about paths, does it? At least the popup
> tooltip shows full paths.

It has nothing to do with full paths. Believe me: I know the
Subversion API and how to use it.
Sure, as long as you only select files you're good to go. But just one
folder in the selection and you then must commit non-recursively
(otherwise you would automatically commit all files and folder within
that folder too).

> > I was thinking more of having the monitoring thread set a flag, and
> > when the user clicks ok show a message that the contents have changed.
> > Automatically refreshing is not good, and interrupting the user with a
> > messagebox while he may be writing a log message isn't good either.
>
> Agreed, especially with the last one. How about changing the OK button to
> Refresh list in this case? Probably requiring too much knowledge on the average
> user's side, wondering where the OK has gone. OTOH the user gets not that much
> (non-technical) information either if a commit fails because of an out-of-date
> file (forgetting to run update before commit) so he might be glad to read
> "refresh" ... ;)

Refresh doesn't mean we do an update, it only means we're fetching the
status of the files again because we've detected that one or more
files have changed since the selection was made.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed May 16 15:43:18 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.