[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Partly revert revision 6174?

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2007-03-18 18:15:53 CET

Hi Stefan,

I would like to revert the part of revision 6174 which contains the
following diff:
--- C:/Development/SVN/TortoiseSVN/src/TortoiseBlame/TortoiseBlame.cpp
(revision 6173)
+++ C:/Development/SVN/TortoiseSVN/src/TortoiseBlame/TortoiseBlame.cpp
(revision 6174)
@@ -1120,6 +1121,9 @@
                 }
                 break;
         case WM_RBUTTONDOWN:
+ if (app.m_selectedrev >= 0)
+ break;
+ // fall through
         case WM_LBUTTONDOWN:
                 {
                         int y = ((int)(short)HIWORD(lParam));

I'm currently implementing the rest of issue 343:

If the user selects a revision with the left button and then clicks on a
different revision with the right button, TortoiseBlame will call "Blame
previous revision" for the revision selected with the left button. This is
wrong as selecting with the right button should also be possible.

The log message of revision 6174 says: "Only selected the revision on
right-click if no other revision is selected. Do not deselect an already
selected revision." which is exactly what it does but in my opinion this
behaviour is wrong.

May I revert this change?

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Mar 18 18:16:17 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.