Re: [PATCH] "Show diffences" when selecting multiple revisions in the log dialog

On Wednesday 08 November 2006 22:52, Stefan Küng wrote:

> > Please review: Is that min(...) I introduced really needed or are the
> > revision numbers always decreasing while iterating. In this case the
> > min(...) could be removed.
>
> Don't remove it!
> It's not defined in which order those entries are shown in the list
> control (sorting).

Well in that case even we also need a max(...) function :-) I've changed it
before committing.

> Just commit it now.

Thanks for the fast response. Committed in revision 7972 and merged into
1.4.x in 7973.

> > + }
> > }
> > POSITION pos =
> > m_ChangedFileListCtrl.GetFirstSelectedItemPosition(); while (pos)
>
> while you're at it: please remove the
> POSITION pos = ...
> and change it to
> pos = ...

Since "pos" is iterating over different lists I'd rather not reuse the
variable. That seems more confusing to me than it is now.

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org