I notice that properties dialog have some problems when show
no-english characters.
But in the edit property dialog there is fine.
problem is here:
=============================
http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseProc/PropDlg.cpp
UINT CPropDlg::PropThread()
{
SVNProperties props(m_Path, m_rev);
m_proplist.SetRedraw(false);
int row = 0;
for (int i=0; i<props.GetCount(); ++i)
{
CString name = props.GetItemName(i).c_str();
CString val = CUnicodeUtils::GetUnicode((char
*)props.GetItemValue(i).c_str());
.......
==========================
and this is fine:
===========================
http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/TortoiseProc/EditPropertiesDlg.cpp
UINT CEditPropertiesDlg::PropsThread()
{
// get all properties
m_properties.clear();
for (int i=0; i<m_pathlist.GetCount(); ++i)
{
SVNProperties props(m_pathlist[i]);
for (int p=0; p<props.GetCount(); ++p)
{
wide_string prop_str = props.GetItemName(p);
std::string prop_value = props.GetItemValue(p);
std::map<stdstring,PropValue>::iterator it =
m_properties.lower_bound(prop_str);
if (it != m_properties.end() && it->first == prop_str)
{
it->second.count++;
if (it->second.value.compare(prop_value)!=0)
it->second.allthesamevalue = false;
}
else
{
it = m_properties.insert(it,
std::make_pair(prop_str, PropValue()));
stdstring value =
MultibyteToWide((char *)prop_value.c_str());
it->second.value = prop_value;
.......
===========================
在 06-9-30，Hanjy<hanjingyu@gmail.com>：
> I want add a svn:keyword property to a lot of files, I selected these
> files, but i cannot find the svn:keyword in dropdown box in add
> properties dialog box. so I must select one file to add the propertiy,
> and then another...
>
> Han
>
>
> 2006/9/27, Stefan Küng <tortoisesvn@gmail.com>:
> > Adam Kania wrote:
> > > Changed with 1.4.
> > >
> > > I noticed that in Subversion pane of the file/folder property dialog –
> > > the svn prorties display is missing. I can access it with another dialog
> > > box, opened by new "Properties…" button.
> > >
> > > Curious why you redesigned what was already an elegant and very friendly
> > > solution.
> > >
> > >
> > >
> > > The immediate problems I have with this design are as follows:
> > >
> > > 1. I can't see property values at once.
> >
> > Sure you can: the properties dialog shows you all properties at once too.
> >
> > > 2. I have to open another dialog box.
> >
> > Or if you want to look at the properties only, then it's not more work
> > as before. Instead of choosing "properties" and changing to the
> > Subversion tab, choose "Properties" in the TSVN submenu. In fact, it's
> > one click shorter than before.
> >
> > > 3. The button to do that doesn't have any shortcut key provided.
> >
> > Added one in revision 7640.
> >
> > > 4. There's a whole lot of unused space in the place, where we used to
> > > have all the properties before.
> >
> > Yes, but why is that bad?
> >
> > > So please tell is it possible to have my properties back? If not please
> > > make it at least configurable.
> >
> > I really don't like to have the same functionality available in two
> > places. Because that means we have to maintain two code parts which
> > mostly do the same (but not *really* the same, code wise).
> >
> > Stefan
> >
> > --
> > ___
> > oo // \\ "De Chelonian Mobile"
> > (_,\/ \_/ \ TortoiseSVN
> > \ \_/_\_/> The coolest Interface to (Sub)Version Control
> > /_/ \_\ http://tortoisesvn.net
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
> > For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
> >
> >
>
--
Tan Ruyan
Site:http://www.iUseSVN.com
Received on Sat Sep 30 04:57:18 2006