Re: [Patch] Issue #278, Load CrashRpt.dll with absolute path

On Wednesday 30 August 2006 18:09, Stefan Küng wrote:
> Tobias Schäfer wrote:
> > Hi Stefan,
> >
> > this patch implements issue #278 "Load CrashRpt.dll with absolute path"
> >
> > I haven't been able to to test the change in StructureFragment.wxs
> > because I don't want to screw up my installation. Maybe I should
> > install a virtual machine for such experiments :-)
> > Does the change look correct and may I commit? I will then test the
> > installation with a nightly build by manually copying CrashRpt.dll and
> > dbghelp.dll into the bin folder.
> >
> > Ok to commit?
>
> I suggest using the GetModuleFileName() API to find the path to the app
> that's running (e.g. TortoiseProc), then strip the filename and append
> the filename of the crash dll. That way, we can load the dll with it's
> full path without using the registry.

Thats a good idea ;-)

Implemented in revision 7533.

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org