[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 284: TortoiseMerge Accelerator Key & Menu Reorganisation

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-09-10 13:32:18 CEST

Jeremy Whitby wrote:
> Stefan,
>
> I've started trying to put a patch together for this issue. It all
> seems quite straightforward apart from one thing, the text block to use.
>
> The current behaviour is for a right click to bring up a menu. The
> position of the right click determines the text block to use. In order
> to use accelerator keys you need to determine the current text block
> cursor position. At present there is no single cursor. Next/Prev
> Difference use m_nDiffStart/End as cursors but somewhat confusingly both
> Next/Prev Conflicts and searching use the m_nSelBlockStart/End cursors.
>
> Should all three functions (Search, differences, conflicts) use the same
> cursor or should we introduce a search cursor and a view cursor to go
> alongside the difference and conflict cursors? Or have I missed
> something when looking at the code?

I think we should just use the same cursor for all three functions
(search, diffs/conflicts and views).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Sep 10 13:32:32 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.