Stefan Küng wrote:
> On 8/31/06, Joseph Galbraith <galb@vandyke.com> wrote:
>> I see... I don't see a good solution then.
>>
>> I think, if it were my call, I'd drop the requirement that
>> they be in the wc, force the hook-script to be an absolute
>> path, and use the 'get permission first' model to deal with
>> security concerns.
>>
>> Actually, how about this, allow two different kinds of
>> paths: absolute local and repository-root relative.
>>
>> o If the path is an absolute windows path, get permission
>> and then run it.
>
> An absolute windows path won't work with project properties - you
> don't know the absolute path on every machine the sourcecode is
> checked out.
> This would only work with a global config file or an entry in the
> settings dialog.
>
>> o If the path is repository-root relative, determine
>> if the file is contained with in the working copy,
>> and warn if not.
>
> to get the repository root, we'd have to contact the repository and
> ask for it first. And since I really don't want (and won't do) to
> contact the repository in e.g. the commit dialog (start-commit,
> pre-commit hooks), this isn't an option either.
Interesting...
> C:\Documents and Settings\galb>svn info e:\users\galb\trunk
> Path: E:\Users\Galb\trunk
> URL: svn+ssh://server/svn/trunk
> Repository Root: svn+ssh://server/dev
> Repository UUID: 0d606a1b-a9ff-564a-b23d-123d731c8e08
It definitely didn't contact the repository, cause I
disabled the network so it couldn't reach the repo.
Maybe that information isn't exposed through the
api...
I've about exhausted my ideas-- maybe there was something
in there that will lead you to the right solution... if not,
at least we know some things that won't work :-)
Ultimately, I guess what I really care about is that:
o The user / admin be able to disable the running
of hooks all together (failure to provide this
option is likely to make some enterprise or
business customers wary.)
o Even if hooks are enabled, the user should be
asked for permission before running the hook
at a given windows path (the first time at least.)
Thanks,
Joseph
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Sep 1 17:21:12 2006