[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG: Icon misalignment

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-08-22 16:48:02 CEST

Simon Large wrote:
> Stefan_Küng wrote
>> Simon Large wrote:
>>> I see this all the time on my work PC. The problem is not that the
>>> overlay is incorrect, it's that it is shown on the .svn folder.
>>> Typically I change a file, and in explorer the file is shown as
>>> unmodified and the .svn folder is shown as modified. I think this may be
>>> due to a race condition within Explorer itself. Is that correct?
>> Yes, it's a race condition in the explorer. Debugging shows clearly that
>> we pass the correct overlay information but the explorer then draw the
>> overlay on the wrong item.
>
> I found the original thread where you describe this:
> http://svn.haxx.se/tsvn/archive-2005-12/0530.shtml
>
> Would it be possible/helpful to modify TSVNcache behaviour so that it holds off
> the update notification for say 0.5 second after the last overlay request from
> the shell? If that works, maybe the update frequency can be increased again so
> that the refresh happens after a commit completes.

That's not the problem (how long we wait until we send the
notifications). The problem is the number of notifications and what item
we send it for. We must send a notification for every item that has
changed its status. The explorer receives those notifications, and
sometimes (I haven't found out the conditions when that happens exactly)
it then resorts the view. Only when that happens you will see this
problem. You can see when the explorer resorts: it behaves exactly as if
you would have hit F5 - usually it just updates the overlays but doesn't
refresh completely.

And besides: we already wait a whole second before we send the
notifications.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Aug 22 16:50:39 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.