[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Small glitches in the new "Edit Properties" Dialog, issue #166

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-03-14 17:38:19 CET

On Tuesday 14 March 2006 13:33, Stefan Küng wrote:
> > - In the "Edit Properties" dialog, please change the first tab-position
> > to the list control. It looks a bit strange if the file name is
> > highlighted when the dialog is opened.
>
> I think setting the focus on the list control would be better than
> changing the tab order.

Thinking about it, it should be exactly the same result. The focus starts at
the list control in both cases and ends at the text field before beginning
again at the list control.

> > - If you set the cursor to a property with the keyboard the add/remove
> > buttons are not activated/named correctly because OnNMClick... is not
> > called when using the keyboard
>
> What message would you recommend to use here?

ON_NOTIFY(LVN_ITEMCHANGED, IDC_EDITPROPLIST,
&CEditPropertiesDlg::OnLvnItemchangedEditProperties)

> Hmmm - doesn't it already work like this? I'll check as soon as I get home.
> But of course, if you select more than one entry to edit the props
> for, it doesn't check if *all* items are files but assumes that it may
> have a folder in the list.

Well, it didn't work in my case. Maybe there are conditions I am not aware of.

Could it be changed to: show the checkbox "recursive" if at least one
directory is selected?

> > Just an Idea: I would like to see this new "Edit Properties" Dialog in
> > the Repo-Browser so that I can set properties there too. Is that
> > possible?
>
> The repobrowser works directly on the repository. Properties must be
> set on a working copy. The only exception are revision properties
> (like "svn:author", "svn:log", "svn:date", ...). Not sure if we should
> provide a dialog to add custom rev props (you can't edit the svn:
> revprops, except "svn:author" and "svn:log", but those can be edited
> from the log dialog).

Thanks for the info.

Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Mar 14 17:39:33 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.