Progress dialog last line somtimes obscured by scroll bar

Hi Stefan,

I know I have mentioned this before, but I think I may have found the
cause this time.

At the end of an update, if the resizing in the first 30 rows causes a
horizontal scrollbar to appear, it obscures the final 'Completed: At
revision N' line. Well in Win2K it does anyway.

Looking in SVNProgressDlg.cpp I see at line 972:

m_ProgList.EnsureVisible(m_ProgList.GetItemCount(), FALSE);

I think that should be:

m_ProgList.EnsureVisible(m_ProgList.GetItemCount() - 1, FALSE);

assuming the list is zero-based.

or possibly more robustly:

int nCount = m_ProgList.GetItemCount();
if (nCount > 0)
     m_ProgList.EnsureVisible(nCount - 1, FALSE);

which looks spookily like the example in MSDN.

Simon

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org