Re: svn commit: r5576 - in trunk/src: . SVN TortoiseProc Utils

Tobias Schäfer wrote:
> On Sunday 29 January 2006 18:43, Stefan Küng wrote:
>
>> Two comments:
>> * when you add new files, please set the svn:eol-style property to
>> 'native'. Otherwise the commit mails get double lines.
>
> I've already corrected that in r5577. Sorry about that.

Yep, just got the commit mail.

>> * You've added a new class 'CDropFiles'. Why didn't you use
>> CDragSourceHelper in the file DragDropImpl.h in src/Utils ?
>
> I had seen that class but since CDropFiles encapsulates the structure
> DROPFILES it needs a own class in my opinion.
> I could have put the source in the file you mentioned but I really prefer a
> separate file in this case.

Ah ok. I think you're right, that's the best way to go.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org