[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r5023

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-11-25 08:16:09 CET

On 11/25/05, Jean-Marc van Leerdam <j.m.van.leerdam@gmail.com> wrote:
> Steve,
>
> Forgive my ignorance if this is not right, but are you sure these
> added lines are correct:
> + if
> (lowerpath.Find(_T("\\tmp\\"))>0)
> + continue;
> + if
> (lowerpath.Find(_T("\\tmp")) == (lowerpath.GetLength()-4))
> + continue;
> + if
> (lowerpath.Find(_T("\\log"))>0)
> + continue;
> + if
> (lowerpath.Find(_T("\\lock"))>0)
> + continue;
>
> I would expect the last two if statements to also match
> '\log_me_as_well' and '\locker'. Don't these need the same treatment
> as the search for '\tmp' at the end of the string?

Not really, unless of course those filenames (\log_me_as_well and
\locker) are *inside* an .svn dir. The check is done only if the path
points to or below an svn admin dir, so this is safe.
(can't access the tsvn repo right now - anyone else having problems?)

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Nov 25 08:16:24 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.