[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] TortoiseSVN looses comments when commit fails.

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-10-05 07:59:54 CEST

On 10/4/05, Thomas Hruska <thruska@cubiclesoft.com> wrote:
> Peter McNab wrote:
> > Stefan Küng wrote:
> >
> >>
> >> Now comes the really hard part: you actually have to look at the
> >> commit dialog!
> >>
> >> 7. Click on the combobox between the edit box where you entered the
> >> log message before and the file list at the bottom.
> >> 8. See and be astonished!
> >>
> > 9 Not see and be admonished! :-)
> >
> > Seeing this comes up regularly, would it help if the last commit message
> > was on display in the combobox when the commit dialog opened?
> >
> > Peter
>
> No. If a commit fails, TSVN should save the comment and automatically
> load the dialog with the same comment when the user goes to commit
> again. There is a minimum 90% probability they will do the same thing
> again.

Bad idea. If you remember, we had that once and many people
complained. First, most of the time if you have to resolve a problem
which made the commit fail, you have to commit some changes to fix
this and *then* repeat the actual commit that failed. So you always
have to remove the previous saved log message first for that
intermediate commit.

> _OR_
>
> Yes...and the user should have to push a button labeled something like
> "Insert" to actually insert the text. Right now the combo box is
> responding to an OnChange() event (or equivalent) and inserting the text
> at the last known position...but that may not be where I wanted it to
> go...so maybe there should be two buttons: "Copy to clipboard" (or just
> "Copy") and "Insert" (or "Auto Insert"). I'd have to see the UI
> positioning of the buttons to determine the exact wording.

And what makes you think that people will notice the "Insert" button
more than the combobox? Also, if we provide a button, then you can be
*absolutely sure* that we'll get several mails a week asking to save
'more than just the last log message'.

And did you really just suggest to add *two* buttons? Please have a
look at the commit dialog again, and then think about where to place
those buttons, and then imagine how the commit dialog would look like
with yet two more buttons. Why do you think I removed the button "pase
file names" and replaced it with an entry in the context menu of the
edit box?

> _OR_
>
> Both except the MRU is blank because the dialog is already loaded with
> the last text used.
>
>
> Also, the combo box is in the wrong position. Most users expect MRUs
> like this one to appear above the text box the MRU refers to. Software
> developers can handle shifts like that because we are used to awkward
> environments, but I view TSVN as eventually being a tool used by the
> average Microsoft Word document user to track their changes.

Ok, can you please give me some examples at least? Where is the MRU
'like this one' at the top of the edit box?
And did you really just compare TSVN with an 'awkward environment'??

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Oct 5 08:00:13 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.