Re: [TSVN] Issue 123

Simon Large wrote:
> Hi folks,
>
> Issue 123 has this comment attached:
>
> > 2 buttons are only usefull if the log dialog is used to
> > actually select something (revision, revision range).
> > If it's used just to show the logs of a file (its main
> > purpose), then a second button would do the same as the
> > first button. There's no difference clicking "OK" or
> > "Cancel" then.
>
> > So I think implementing 1) is enough. 2) shouldn't be done.
>
> I agree that having 2 buttons which do the same would not be an
> improvement. I don't know how easy it is to change the button text and
> hide buttons at run time. Ideally I would like to see:
>
> Normal show log (no action on close):
> 1 Button with text = 'Close'
>
> From Merge dialog where a rev or range is being selected:
> 2 buttons with text 'Select' and 'Cancel'.
> I suppose in this case, the 'Select' button should be greyed out if no
> revision is selected.
>
> Is that a worthwhile change?

Please reopen the issue and add this comment there.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org