SteveKing wrote:
> Alexander Klenin wrote:
>
>> After upgrading to TSVN 1.2.0 I noticed that double click no longer
>> works in log dialog.
[snip]
>> 2) AFAIU, "select between different revisions" is only possible in
>> the revisions list in upper part of the dialog. But what about the
>> lower part, the files list? I see no possibility for conflict there.
>
> It was removed there for consistency.
At risk of beating a horse some might prefer left for dead, I have to
agree with the idea of Alexander's original post: Since viewing
individual file diffs (*in the lower paths pane*) is such a frequently
done operation, having double-click automatically do that was *really*
nice. Removing that has been my only (minor) pain in moving to 1.2.
As I understand it, the potential "wait a long time" problem is in the
top "revision" pane only, so that's where it only *needs* to be
disabled, but the argument was "for consistency, remove it everywhere".
In actual practice, however, I've found it made consistency worse,
here's why:
The Commit and Show Log dialogs are very similar. They both show the
log message, and below it the list of changed paths. In my workflow,
whenever I commit I'll double-click each file (in the commit dialog this
still brings up a diff) to double-check my changes. Similarly, when I
want to examine history I'll click a revision in the Log Viewer, read
the log message, and then double click any interesting files in the
paths pane, in order to see exactly what changed. This used to work,
but now I have to right-click each file and choose "Show Differences".
The inconsistency between paths panes in these dialogs now forces me to
pause and ask myself "can I just double click, or do I have to
right-click?" before view differences.
Since diffing individual files is so common (compared, I'd wager, to
whole revisions), and the paths panes of Commit and Show Log dialogs are
so similar, I think restoring double-clickability in the Show Log
dialog's paths pane and thus maintaining double-click consistency
between the dialogs is more important than going for consistency between
the revision and paths panes in the Show Log dialog.
> Also, in other apps if you accidentally do a doubleclick instead of a
> normal click, you don't block the whole app for several seconds
> (sometimes even minutes). In the TSVN log dialog, you can easily block
> it for several minutes if you doubleclick on an early revision and do a
> diff of that revision with your wc...
As I understand it, this is something that will be fixable after
Subversion starts using neon 0.25 and adds better support for
"streamyness". (IIRC from the svn dev list, this was discussed for
1.4/5) I think most would agree that the ideal here is not to make some
operations a little harder to do in case of a mistake, but rather to let
the user easily cancel any mistaken operation. So in the future
double-click for the "revision" pane could also be re-enabled, restoring
"full consistency".
Can I convince you, Stefan? :)
-Nathan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Jun 8 18:30:42 2005