[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] [PATCH] Log messages list sorting

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-06-04 09:45:19 CEST

Boris wrote:
> Attached is the patch for the log messages list sorting. This is just
> something I was always missing but never dared to ask for :). I also took
> the freedom to reorganize log data arrays into the single structure.
>
> Log messages sorting patch:
> * Implemented log list control sorting.
> * Shown-list CDWordArray array replaced with the CPtrArray array.
> * Individual log lists replaced with the helper LogEntryData structure.

Thanks a lot for that patch! It's really great.

I did some minor tweaks:
- the bitmap for the header looks really ugly with non-standard color
schemes. I removed them and use the windows arrays instead (won't show
on < XP systems though :( )
- prevented sorting while the fetch-thread is running

Now I'll work on sorting the pathlists too. ;)

One thing that worries me a little is the method SortShownListArray()
which has two nested for() loops. I think we have to do something about
that.

Committed your patch with my tweaks in revision 3622.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Jun 4 09:45:54 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.