[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Re: svn lock returns null for username

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-02 21:32:15 CEST

On Mon, 2 May 2005, Ben Collins-Sussman wrote:

>
> On May 2, 2005, at 2:06 PM, Mark Phippard wrote:
> > OK, I can see what this "problem" is. I will let you decide if you
> > should
> > fix it or not. r14543 now gets the lock owner out of a custom header.
> > However, this header was not sent by the server prior to this fix. So
> > my
> > problem would occur when using an RC2+ client with an RC2 or earlier
> > server. Once the server is on RC2+ it will be sending the header that
> > the
> > client is looking for.
> >
> > Perhaps the client could fallback to ras->auth_username if it does not
> > get
> > the header?
> >
>
> Nope, this is definitely not a bug. rc2 is not an official release...

It's a bug, because the client doesn't do proper input validation and
thereby violates its API by returning a NULL lock->owner.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon May 2 21:40:28 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.