Re: [TSVN] [Patch] Explorer Lockup resolved?

Norbert Unterberg wrote:

> I thought that would be the reason. However, I think that
> WaitNamedPipe() on the server side will either always return immedatiely
> (becausue a pipe instance has been created) or always fall into the
> timeout (because ConnectNamedPipe has not been called). WaitNamedPipe
> does *not* wait until a client has been connected to a server pipe. But
> I may be wrong, I have not stepped through that line of code.

You may be right here, I don't know. I take any advice on this subject.

> To terminate the pipe threads in a clean way there are better ways than
> the global bRun flag. I might create a patch for that some other time.

What do you have in mind? Ok, the global flag isn't really that good,
but it's almost the same as passing the pointer to that variable to the
thread.

>> The patch looks very good. I'm currently doing some testing with it.
>> As soon as you give the 'go' signal, I'll commit it.
>
> I can NOT give you a 'go'. Currently I am trying to debug the client
> part: When you terminate TSVNCache, the shell does not restart it. Do
> you have an idea what I broke?

The ClosePipe() method doesn't invalidate the m_hPipe in case of an
error. I added
m_hPipe = INVALID_HANDLE_VALUE;
in line 183 and 86, just before the call to ClosePipe(). Then it works.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org