[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locked overlay

From: Andrew Vaughan <ajv-lists_at_netspace.net.au>
Date: 2005-04-13 22:47:55 CEST

On Thu, 14 Apr 2005 04:51 am, SteveKing wrote:
>
> >>- If you don't have the lock, the file is readonly and you can't
> >> edit it.
> >
> > Not true, editors are NOT guaranteed to care diddly-squat about
> > read-only being set.
>
> If an editor ignores that flag, that editor is broken. Really!
>
Agreed.

But such broken programs exist. From memory notepad write and some
versions of ms word all have this problem. (I can't check now.)

They allow you to edit a read-only file without complaining. It is only
when you try to save the file that you discover the problem.

It's possible to do hours of work before attempting to save.

> > Read-only is a residue from the good old DOS days, it's not
> > guaranteed to mean anything to a Windows application. Windows
> > applications are what TSVN has to do with.
>
> Not quite true. The windows API still uses that flag. That flag works
> on windows as it did on DOS, and it's also very well documented. Yes,
> the ACL's give more options on how a file is readonly and for who,
> but the readonly flag still says readonly-for-all-users.
> For example, the WriteFile() API (a 32-bit Windows-API) throws an
> error if a file has a readonly flag set, so it's not just for DOS but
> for windows too.
> An editor would have to remove that flag before being able to save a
> file - if an editor does that without asking the user first I'd call
> such an editor broken.
>
> >>- if you have the lock, you can edit the file
> >
> > And if you don't, you can as well. Whoop-ti-doo..
>
> Only if the svn:needs-lock property isn't set. No change to the
> current implementation.
>
> >>in both cases the svn:needs-lock property is set.
> >
> > So it is.
> > And it's effect should be that TSVN tells the user "you need to
> > lock this file".
>
> As I mentioned now twice: it doesn't tell the user "you need to lock
> this file", it only tells you that you *might* need to lock the file.
> The property is set even if you already *have* locked that file!
>

how about
Show an overlay:
no overlay -> svn:needs-lock prop not set
lock icon red variant -> svn:needs-lock prop set; lock not held
lock overlay green variant -> wc holds lock. (svn:needs-lock irrelevent)

> Stefan

-- 
Andrew V.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Apr 13 22:42:46 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.