Re: [TSVN] Re: still buggy

Molle Bestefich wrote:

> Nonetheless:
>
> 1. The bug as described in the issue tracker is not fixed. It should
> be reopened. No point in closing a perfectly valid bug description.
> Remove it from the 1.1.4 milestone if you think it's not important
> that it be fixed now (I think the milestone needs an update anyway?).

Well, the issue is fixed. At least as far as it can be fixed without a
severe performance degradation or not using the cache at all.

> 2. Ok. I'll throw some ideas around, there's got to be a way to fix.
> How about this:
> Whenever a refresh (F5) occurs, don't make an entire treewalk.
> Instead, for each item that is found to have an entry in the cache:

There is no way to find out if an refresh (F5) is requested or not. We
only get requests, if that's because of an F5 or not we don't know.

> - Check that it has a .svn folder. If it doesn't, remove it from the
> cache (or set a 'needs_update' mark on the item in the cache..
> whatever's fastest) and skip applying the overlay

Checking for an .svn folder will require a PathFileExists() which is a
very expensive function and requires disk access. That's why this is
cached and only done if the cache timeouts.

> - Check the timestamp on the ".svn/entries" file (applies for all
> files that's being checked) or the "<wc folder>/.svn/entries" file
> (applies for all folders that's being checked). Compare it with a
> cached value. If the timestamp has changed, the item needs to be
> refreshed. To avoid the treewalk delay, set a needs_update flag on
> the item in the cache scheduling it for a refresh and just return a
> blank overlay on the item for now.

Again here: all these are expensive function calls and are therefore cached.

So the issue *is* closed - when the cache times out it will be shown
correctly, but not sooner. Otherwise we would have to get rid of caching
and then we couldn't call it 'cache' anymore.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org