[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Feature request: Remove from ignore list

From: Simon Large <slarge_at_slarge.plus.com>
Date: 2005-02-19 23:44:50 CET

SteveKing wrote:
> Simon Large wrote:
>> When I right click on an unversioned file I get the option:
>>
>> Add to ignore list ->
>> Filename
>> *.ext
>>
>> After ignoring the file, if I right click again, I get the same
>> options, which doesn't make sense.
>
> Can you give me a reproduction recipe for this? I just tried that, and
> for ignored files I don't get the 'add to ignore list' menu at all!

I have a test folder which contains 1 versioned file.
In that folder create a new text file "New Text Document.txt"
Right click on file and select add to ignore list->New Text Document.txt
Confirmation dialog appears.
Check properties of parent folder, svn:ignore includes that file.
Right click on file again, add to ignore list is still there.
...BUT...
After I commit, that option goes away.

>
>> A more useful option would be for the context menu to check an
>> unversioned file to see if it is already ignored. If it is, then
>> present the menu as:
>>
>> Remove from ignore list ->
>> Filename
>> *.ext
>
> That would only work if the context menu extension would read the
> properties and check which one is set to ignore that specific file
> (i.e. if it's ignored by filename or extension mask). And it would
> break completely if the user set the ignore property manually to
> something TSVN wouldn't expect (e.g. Filename_*.ext).
> So while this is a good idea and definitely a wonderful feature, I
> won't do it right now - maybe in some time when I thought about a way
> to do that reliably.

More difficult than I thought. Also, it may match on multiple keys, but
you can't know that. I would suggest _only_ offering the obvious
choices. If it's more complicated, then you have to use the properties
tab. This is mainly to help out people who added files by mistake, so in
that case it would have to be specific filename or *.ext that was added
by mistake.

I suggest:
If there is an exact filename match in svn:ignore, offer that
(Else) if there is an extension match in svn:ignore, offer that
Else don't offer the menu at all.

I am not sure about the first Else. If it matches an exact filename and
wildcard extension, should you offer both? I think not. If a specific
filename was added, then it is very likely that _only_ that specific
filename should be removed.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Feb 20 00:06:35 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.