Re: [TSVN] Tempfile vs. actual path

Will Dean wrote:

> Although I appreciate that this represents a rich seam of software
> archeology, there for the pleasure and amusement of our grandchildren,
> *personally*, I find it rather a pain. Especially when it induces me to
> break things (like import), which Stefan then has to fix...

I'm used to fix things ;) Mostly because I break them myself ;)

> Of course, it doesn't make much difference to most end-users, because
> the shell extension knows all the various rules and acts accordingly.
>
> I would like to propose the following changes:
>
> 1. All commands default to assuming that the /path: argument is a temp
> file containing a list of paths.
> 2. To avoid point 1 causing death and destruction during the changeover,
> TortoiseProc should only delete a path temp file if it has a .tmp
> extension.

Agreed.

> 3. All commands should honour the /notempfile switch.

And with /notempfile, we have to make sure that a list of paths,
separated by '*' works too. Otherwise people using TSVN from an IDE will
have big problems.

> If we do this, then I can hoist all the processing of the tempfile out
> to one place at the top of TortoiseProc, and pass a reference to a
> CTSVNPathList around to everything else.
>
> Can anyone see any problems with this? (Other than the spate of
> regressions I shall cause as I blunder about in the code)

I don't think this would cause any problems. We just have to be careful
to not pass a tempfile to functions which don't expect one: such
functions will have to be changed to use the tempfile first.

> Clearly people who have written batch files to talk to TortoiseProc
> *might* have to change them, but at least they'll be changing them to
> match the documentation, and I think point 2 above will prevent them
> having files suddenly deleted.

Since we don't have a policy to not break the 'API' (in TSVN's case the
command line params), those people can't really blame us ;)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org