Re: [TSVN] "Show overlays only in explorer" contentions

Pete Gonzalez wrote:

> eventually took me to this little hack in TortoiseSVN IconOverlay.cpp:

That's not a hack but a feature.

>> if(!bAllowOverlayInFileDialogs)
>> {
>> // Test if we are in Explorer
>> TCHAR buf[_MAX_PATH + 1];
>> DWORD pathLength = GetModuleFileName(NULL, buf,
>> _MAX_PATH);
>> if(pathLength >= 13)
>> {
>> if ((_tcsicmp(&buf[pathLength-13],
>> _T("\\explorer.exe"))) != 0)
>> {
>> return S_FALSE;
>> }
>> }
>> }
>
>
>
> When I renamed the app to "explorer.exe", sure enough the icons magically
> appeared. And it turns out there is a GUI checkbox for "Show overlays only
> in explorer", which I guess I must have checked at some point.

See? It's a feature which you obviously have used!

> I felt a little stupid, but I don't think my interpretation was
> unusual. IMO
> there's something fundamentally wrong about equating Explorer.exe with
> Windows Explorer, since the "explorer" functionality can be accessed
> from many different processes (e.g. from iexplore.exe). I mean, the "e"
> isn't even capitalized in that caption. :-)

That's exactly what this feature is for: limiting TSVN to only work with
the bare windows explorer. If it is started from another application
(e.g. when the app uses the "Save As..." dialog) TSVN won't show up.
People requested that because some other apps either cause problems with
that or they don't want to have the overlays shown for simple operations
from apps they don't need TSVN anyway.

And if you check the code again: we don't just check for "explorer.exe",
we check for "\\explorer.exe". So iexplore.exe will never be confused
with that.

> I would like to suggest that we rename the checkbox to "Show overlays only
> for the Explorer.exe process," or at least mention in the tooltip that

Most people don't know what Explorer.exe is, not to mention a process.
People don't work with processes, they work with apps.

> dialogs are not the only place where the overlays will be disabled. (Or
> an even better approach might be to let the user input a list of process
> names.)

A list of processes? Come on, that would be a little too much
configuration for not even 1 in thousand people really needing it.

> It's not a big deal, but maybe it could have saved me those hours I wasted
> debugging COM interfaces. ;-D

Reading the docs might have helped too!

May I ask what application you're working on?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org