Re: [TSVN] "diff" command in context menu when selecting an added file

On Thu, 06 Jan 2005 12:14:38 +0000, Will Dean <svn@indcomp.co.uk> wrote:

> >That's the whole discussion about: shall we deactivate the menu if
> >it's a plain "add" or not. I think we should activate it anyway -
> >TortoiseMerge can handle even that ;)
>
> But if we don't enable Diff unless it's an Add AND the 'Copied' flag is
> set, then we will never call a merge program with a missing file.

That's what I mean: I don't want to disable the menu if it's a clean
add - TMerge can handle non-existing files and just shows an empty
file on the left and the added file on the right. Maybe other visual
diff tool can do that too - or they will be able to do so one day.

> OK. While you're in there, would it be possible to make GetCachedItem
> private to SVNFolderStatus, and only call GetFullStatus from outside
> SVNFolderStatus?
>
> That way all the details of cache hitting and missing and building are
> encapsulated within SVNFolderStatus, and then consumers of the status
> information (there's about to be another one added) won't need to know
> anything about the operation of the cache.

If you remember: it was you who created the function GetCachedItem()
for speed reasons: that way we can prevent a call to PathIsFolder if
the item already is in the cache. Only if it's not in the cache, then
we have to call that.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org