[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Big Lint-cleaning patch

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2004-12-16 16:59:16 CET

Hi,

The attached is a huge patch, which cleans-up various Lint-type errors.

As ever when you run Lint on a project for the first time, the results are
completely overwhelming. I have rather skimmed through the output, just
doing safe/easy stuff - there is a lot of:

1. Converting CString parameters to const CString&
2. Explicitly casting CStrings to LPCTSTRs when they're passed into a
var-arg function (usually Format(...) )
3. Some attempt to deal with uninitialised data members.
4. Another big go at the tangle of #includes - should further improve build
times.
5. A fairly big go at variables which have names which hide identifiers in

I have marked various things in the code with //BUGBUG comments - these are
where I'm getting warnings about something but I am hesitant about changing
it. Stefan, could you have a look at these sometime?

There is a change around line 1365 in CLogDlg which I think is a correction
for a bug - I think the Find() should have been using the lower-case text,
not the original test - Lint warned me that the CString named 'find' (not a
very good name, really...) was not being referenced.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Thu Dec 16 17:00:39 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.