[TSVN] Re: Rev 2089: Please take a close look

SteveKing schrieb:

> Norbert Unterberg wrote:
>
>> Allocating and fetching a 10K error message on the stack and not even
>> using it

> 10k isn't very much to allocate on the stack.

Well, I know 20 KB on the stack (TCHAR on a unicode build?) is nothing
to really worry about (although I would have chosen a CString there
because of the dynamic texst allocation ... you are using MFC, aren't
you?). Did you read the second half of my sentence?

I believe you do not output the error message at all:

   pE->GetErrorMessage(error, 10000);
   CMessageBox::Show(NULL, ERROR, _T("TortoiseSVN"), MB_ICONERROR);

I see you displaying _ERROR_ instead of _error_.

> But since I got reports that the update command sometimes just
> doesn't update at all and _no_ error message is shown, I guess that the
> pE->ReportError() just doesn't work.

I never had problem with CException::ReportError(), but only if I really
called it. It can not display an error if you do not call it, and you
forgot to call it in most of the CFileException handling code ;-)

Norbert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Dec 10 21:15:06 2004