[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Re: Move files lists extra entries

From: Simon Large <slarge_at_blazepoint.co.uk>
Date: 2004-11-25 19:27:31 CET

SteveKing wrote:
> Nathan Creek wrote:
>> Right-click drag Sub2 into Subfolder.
>> Choose "Move files in subversion to here".
>> Choose either Commit, or Check for Modifications
>>
>> The entries listed are
>> Sub2: deleted
>> Sub2/File1.txt: deleted
>> Sub2/File2.txt: deleted
>> Subfolder/Sub2: added
>>
>> For some reason File1.txt and File2.txt are being listed when they
>> shouldn't be. This happens for both moving and renaming a folder.
>
> Why do you think that File1.txt and File2.txt should not be listed?
> They're getting deleted too. So they should be listed (I think). Sure,
> you can't commit Sub2 without committing Sub2/File1.txt and
> Sub2/File2.txt, but at least you can see what's getting deleted when
> you delete Sub2.

I think what is confusing here is that the files are listed as deleted
but not added. To present a consistent picture to the user the list
should read either:

>> Sub2: deleted
>> Sub2/File1.txt: deleted
>> Sub2/File2.txt: deleted
>> Subfolder/Sub2: added
>> Subfolder/Sub2/File1.txt: added
>> Subfolder/Sub2/File2.txt: added

or more simply:

>> Sub2: deleted
>> Subfolder/Sub2: added

What happens if you deselect any of those file adds and deletes is a
worry. Probably it should refuse to commit. Maybe you should simply
filter out the file deletes, so the move _has_ to be done recursively.

Simon

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Nov 25 19:27:08 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.