Fwd: Re[2]: [TSVN] [BUG] Problem with detection of changes in svn:externals included folders

Sorry for replying to you directly. Forgot to add 'CC' :/.

------------- Forwarded Mail -------------
From: Dmitry Radzevich <dsr@orga.ru>
To: SteveKing <steveking@gmx.ch>
CC:
Created: Fri, 19 Nov 2004 20:10:38 +0300
Subject: [TSVN] [BUG] Problem with detection of changes in svn:externals included folders
Attachments: <none>

Hi.

> Dmitry Radzevich wrote:

>> I think I've found a bug in changes detection in svn:externals folders.
>>
>> The working copy is laid out as follows:
>>
>> /project
>> |
>> |-----/emulation
>> | |
>> | |---/libs (all folders under '/libs' are included via svn:externals prop on '/libs')
>> | |
>> | |---/lib1
>> | |---/lib2 (also contains some unversioned files)
>> |
>> |-----/src (versioned folder, with some modified and added files)
>>
>>
>> The problem is: when I say 'Commit...' from the '/project' folder, I see a
>> message box in the commit dialog saying that 'Modifications detected in
>> svn:externals included folders. Those mods are not listed, you'll have to
>> commit them manually'. That's OK, I wasn't going to commit those changes
>> anyway. But the commit dialog doesn't list any modified or added files from
>> the '/project/src' folder.
>>
>> Seems like when TSVN detects changes in svn:externals included folder, it stops
>> scanning the working copy.

> Sorry for the delayed answer, I was away for a whole week.

> Now about your problem: I just tried to reproduce it exactly with the
> layout you described above (well, my 'project' folder is called 'test',
> but that doesn't matter anyway). But when I try to commit from the
> project folder ('test' in my case here), I get the message dialog
> telling about mods in externals, but the modifications and added files
> in /src get listed as they should.
> Maybe I should mention that I'm trying this with HEAD, i.e. the most
> current dev version.
> Maybe you can try with the latest nightly build and report back if it
> still doesn't work correctly for you?

Ok, I'll give it a try when I have some time...

>> BTW it would be helpful, If one could disable the warning about changes in
>> svn:externals folders altogether.

> Hmmm - wouldn't that be a little bit dangerous? I mean yes, most of the
> time that message is annoying. But then someday you have mods in your
> externals and if nothing tells you that you forget to commit them...

That's why I'd like to see it as an option. For most of our projects,
svn:externals are just binary libraries, which shouldn't be modified
anyway (at least, not in svn:externals locations).

I actually think that even unversioned files in svn:externals'
folders could actually trigger that warning in the commit dialog (maybe
they are seen as possible candidates for an 'svn add'?).

> Stefan

--
Best regards,
 Dmitry Radzevich
------------- End of Forwarded Mail -------------
--
Best regards,
 Dmitry Radzevich
---------- Пересылаемое письмо ----------
От:                  Dmitry Radzevich <dsr@orga.ru>
К:                   SteveKing <steveking@gmx.ch>
А также к:           
Время создания:      Fri, 19 Nov 2004 20:10:38 +0300
Тема:                [TSVN] [BUG] Problem with detection of changes in svn:externals included folders
Прикрепленные файлы: <none>
Hi.
> Dmitry Radzevich wrote:
>> I think I've found a bug in changes detection in svn:externals folders.
>> 
>> The working copy is laid out as follows:
>> 
>> /project
>>  |
>>  |-----/emulation
>>  |      |
>>  |      |---/libs (all folders under '/libs' are included via svn:externals prop on '/libs')
>>  |           |
>>  |           |---/lib1
>>  |           |---/lib2 (also contains some unversioned files)
>>  |
>>  |-----/src (versioned folder, with some modified and added files)
>> 
>> 
>> The problem is: when I say 'Commit...' from the '/project' folder, I see a
>> message box in the commit dialog saying that 'Modifications detected in
>> svn:externals included folders. Those mods are not listed, you'll have to
>> commit them manually'. That's OK, I wasn't going to commit those changes
>> anyway. But the commit dialog doesn't list any modified or added files from
>> the '/project/src' folder.
>> 
>> Seems like when TSVN detects changes in svn:externals included folder, it stops
>> scanning the working copy.
> Sorry for the delayed answer, I was away for a whole week.
> Now about your problem: I just tried to reproduce it exactly with the
> layout you described above (well, my 'project' folder is called 'test',
> but that doesn't matter anyway). But when I try to commit from the 
> project folder ('test' in my case here), I get the message dialog 
> telling about mods in externals, but the modifications and added files
> in /src get listed as they should.
> Maybe I should mention that I'm trying this with HEAD, i.e. the most
> current dev version.
> Maybe you can try with the latest nightly build and report back if it
> still doesn't work correctly for you?
Ok, I'll give it a try when I have some time...
>> BTW it would be helpful, If one could disable the warning about changes in
>> svn:externals folders altogether.
> Hmmm - wouldn't that be a little bit dangerous? I mean yes, most of the
> time that message is annoying. But then someday you have mods in your
> externals and if nothing tells you that you forget to commit them...
That's why I'd like to see it as an option. For most of our projects,
svn:externals are just binary libraries, which shouldn't be modified
anyway (at least, not in svn:externals locations).
I actually think that even unversioned files in svn:externals'
folders could actually trigger that warning in the commit dialog (maybe
they are seen as possible candidates for an 'svn add'?).
> Stefan
--
Best regards,
 Dmitry Radzevich
---------- Конец пересылаемого письма ----------
-- 
С уважением,
 Дмитрий Радзевич
Старший программист
Центр разработки новых продуктов
ЗАО "ОРГА Зеленоград"
124527, Россия,
Москва, Зеленоград,
Солнечная аллея, д. 3
тел.:   +7095 785-8346
факс:   +7095 532-9267
e-mail: dsr@orga.ru
WWW:    http://www.orga.ru/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org